Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete crds, and fleets, gameservers etc on deletion of Helm chart #426

Closed
markmandel opened this issue Nov 26, 2018 · 0 comments
Closed

Delete crds, and fleets, gameservers etc on deletion of Helm chart #426

markmandel opened this issue Nov 26, 2018 · 0 comments
Assignees
@EricFortin
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/feature New features for Agones
Milestone
0.7.0

Comments

@markmandel
Copy link
Member

Due to #375 - the crds are not managed by Helm, so they are left behind on deletion of the chart.

Also, if you delete the helm chart before removing your Fleets and GameServers, you can get stuck GameServers, and it can be a pain to cleanup.

We should write a post-delete hook (or whatever is appropriate) to do the cleanup when deleting the Helm chart to clean all the things up.

Context: https://github.com/helm/helm/blob/master/docs/charts_hooks.md#hook-resources-are-not-managed-with-corresponding-releases
@markmandel markmandel added kind/feature New features for Agones help wanted We would love help on these issues. Please come help us! good first issue These are great first issues. If you are looking for a place to start, start here! area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Nov 26, 2018
@markmandel markmandel changed the title Delete crds, and fleets, gameservers etc on deletion on Helm chart Delete crds, and fleets, gameservers etc on deletion of Helm chart Nov 26, 2018
@EricFortin EricFortin self-assigned this Nov 28, 2018
@EricFortin EricFortin mentioned this issue Dec 2, 2018
Merged
@markmandel markmandel added this to the 0.7.0 milestone Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EricFortin EricFortin

Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/feature New features for Agones
Projects
None yet
Milestone
0.7.0
Development

No branches or pull requests
2 participants
@markmandel @EricFortin