Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example allocation yaml files to use selectors instead of required #2771

Closed
roberthbailey opened this issue Oct 20, 2022 · 1 comment · Fixed by #2787
Closed

Update example allocation yaml files to use selectors instead of required #2771

roberthbailey opened this issue Oct 20, 2022 · 1 comment · Fixed by #2787
Labels
area/examples Examples. Usually found in the `examples` directory good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/cleanup Refactoring code, fixing up documentation, etc kind/feature New features for Agones
Milestone

Comments

@roberthbailey
Copy link
Member

Is your feature request related to a problem? Please describe.
examples/gameserverallocation.yaml uses the newer selectors but a lot of the yaml files under the /examples directory still use required (e.g. examples/simple-game-server/gameserverallocation.yaml and examples/xonotic/gameserverallocation.yaml but probably others as well).

Describe the solution you'd like
Search through the game server allocation yaml files checked into the repository and change the spec to use selectors instead of required

Describe alternatives you've considered
n/a

@roberthbailey roberthbailey added kind/feature New features for Agones help wanted We would love help on these issues. Please come help us! good first issue These are great first issues. If you are looking for a place to start, start here! kind/cleanup Refactoring code, fixing up documentation, etc area/examples Examples. Usually found in the `examples` directory labels Oct 20, 2022
@markmandel
Copy link
Member

I have the updates for STK example in a branch, I'd just forgotten about it. I'll publish this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/examples Examples. Usually found in the `examples` directory good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/cleanup Refactoring code, fixing up documentation, etc kind/feature New features for Agones
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants