Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Kubernetes 1.22 #2494

Closed
22 tasks done
markmandel opened this issue Feb 24, 2022 · 7 comments · Fixed by #2562
Closed
22 tasks done

Upgrade to Kubernetes 1.22 #2494

markmandel opened this issue Feb 24, 2022 · 7 comments · Fixed by #2562
Assignees
Labels
area/operations Installation, updating, metrics etc kind/feature New features for Agones
Milestone

Comments

@markmandel
Copy link
Member

markmandel commented Feb 24, 2022

List of items to do for upgrading to 1.22:

  • Update terraform submodules
    • GKE
    • Azure
    • EKS
  • Update prow cluster to use 1.22 (even though we aren't using it yet, we should keep it in sync)
    • Recreate cluster with new scripts: cd build/terraform/prow; terraform apply -var project=agones-images
  • Update e2e cluster to run against 1.22
    • Recreate cluster with new scripts: cd build/terraform/e2e; terraform apply -var project=agones-images
  • Update kubectl in dev tooling
    • Update kubectl in build/build-image/Dockerfile
    • Update kubectl in build/e2e-image/Dockerfile
  • Update documentation for creating clusters to 1.22
    • Config.toml supported_k8s and related (do dev_ before main)
  • Update the dev tooling to create 1.22 clusters
    • Minikube
    • Kind
  • Update client-go
  • Update CRD API reference
    • Update links to k8s documentation in site/assets/templates/crd-doc-config.json
    • Regenerate crd api reference docs - make gen-api-docs
  • Regenerate Kubernetes resource includes (e.g. ObjectMeta, PodTemplateSpec)
    • Start a cluster with make gcloud-test-cluster, uninstall agones using helm uninstall agones -n agones-system, and then run make gen-embedded-openapi and make gen-install
@markmandel markmandel added kind/feature New features for Agones area/operations Installation, updating, metrics etc labels Feb 24, 2022
@1804devs
Copy link

  1. I edited terraform submodules but i have a older chromebook so i wont be able to run terrform apply etc ..
  2. I'll like to work on all 22 issues will i be able to without a ide

@markmandel
Copy link
Member Author

@1804devs thanks for the offer - you will want to be able to test out any changes, so unfortunately you likely will need some kind of development environment, yes to ensure there are no issues.

@1804devs
Copy link

markmandel

Thanks for reaching back. Im looking into github/ codespace to help . I'll keep you up todate

@roberthbailey roberthbailey self-assigned this Apr 22, 2022
@roberthbailey
Copy link
Member

@1804devs - if you are looking for a good issue to get started, you might want to check out the open issues labeled "good first issue".

@roberthbailey
Copy link
Member

Trying to recreate the e2e-test-cluster I get the following error from our terraform script:

$ terraform apply -var project=agones-images
module.gke_cluster.null_resource.test-setting-variables: Refreshing state... [id=231080905775840212]
module.gke_cluster.google_container_cluster.primary: Refreshing state... [id=projects/agones-images/locations/us-west1-c/clusters/e2e-test-cluster]
helm_release.consul: Refreshing state... [id=consul]
╷
│ Error: Kubernetes cluster unreachable: invalid configuration: no configuration has been provided, try setting KUBERNETES_MASTER environment variable
│ 
│   with helm_release.consul,
│   on module.tf line 59, in resource "helm_release" "consul":
│   59: resource "helm_release" "consul" {
│ 

@roberthbailey
Copy link
Member

It turns out that it was a red herring. I'd run terraform init / apply before deleting the cluster (to see the diff) and since I had an existing .tfstate file it had cached some information about the current state of the world. After deleting and re-running terraform init things are working as expected.

@roberthbailey
Copy link
Member

After recreating the e2e cluster I noticed that it only had 10 nodes (8 in the default pool and 1 each for metrics and agones system). The older e2e cluster had 12 nodes, so I've manually scaled this cluster up by 2 nodes to match the old cluster's size. I will update https://github.com/googleforgames/agones/blob/main/build/terraform/e2e/module.tf so that manual intervention isn't required next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/operations Installation, updating, metrics etc kind/feature New features for Agones
Projects
None yet
4 participants