HealthCheckLoop Never invoked in C# SDK

[stevenflautner]

What happened:
Agones Game Server becomes Unhealthy because Health is never signaled by the SDK.
HealthCheckLoop function is never invoked in Agones Game Server SDK for C#

What you expected to happen:
HealthCheckLoop function should be invoked by the SDK in AgonesSDK.cs and since it being private there's no way to call it externally.

		private async Task HealthCheckLoop()
		{
			while(!cts.IsCancellationRequested)
			{
				if(HealthEnabled)
					await HealthAsync();
				await Task.Delay(HealthInterval * 1000);
			}
		}

How to reproduce it (as minimally and precisely as possible):
Use the AgonesSDK for C#

Anything else we need to know?:

Environment:

• Agones version: SDK 1.0.2
• Kubernetes version (use kubectl version):
• Cloud provider or hardware configuration:
• Install method (yaml/helm):
• Troubleshooting guide log(s):
• Others:

[aLekSer]

There is a lack of SDK conformance tests as well as Unit Tests for this functionality. So there is a need to fix C# SDK.

[aLekSer]

For now you can call HealthAsync.

agones/sdks/csharp/sdk/AgonesSDK.cs

Line 275 in 0850d9e

internal async Task<Status> HealthAsync()

HealthCheckLoop is redundant, I could not find such functionality in Golang SDK.

[markmandel]

@Davidnovarro this is a bug against the C# SDK. #1598 is a PR against the Unity SDK, they are different SDKs.