Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc-gateway powered REST API for MultiCluster Allocation #1495

Closed
markmandel opened this issue Apr 25, 2020 · 2 comments · Fixed by #1902
Closed

grpc-gateway powered REST API for MultiCluster Allocation #1495

markmandel opened this issue Apr 25, 2020 · 2 comments · Fixed by #1902
Labels
area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc help wanted We would love help on these issues. Please come help us! kind/feature New features for Agones
Milestone

Comments

@markmandel
Copy link
Member

Is your feature request related to a problem? Please describe.

For users for which gRPC isn't a viable option, it would be handy to have a REST based API as well for the gPRC API.

Describe the solution you'd like

We use grpc-gateway to generate the REST API, but also use the same certificates to authenticate the endpoint as we would for the gRPC endpoint.

We can also generate a swagger.json so that people can generate REST clients as well.

Describe alternatives you've considered

Having no REST endpoint. But we're seeing bugs around SSL cert management in other languages, and this would provide a workaround for any other issues we have in the future.

Additional context

I would recommend completing #1331 first.

It might also be worth updating grpc-gateway at some point as well, we're quite a few releases behind.

@markmandel markmandel added kind/feature New features for Agones area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Apr 25, 2020
@pooneh-m pooneh-m added the help wanted We would love help on these issues. Please come help us! label Apr 30, 2020
@Davidnovarro
Copy link

REST API should be ok.

@robbieheywood
Copy link
Contributor

+1 - we'd really like this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc help wanted We would love help on these issues. Please come help us! kind/feature New features for Agones
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants