Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two light weight and medium weight missing in variable font #190

Closed
WordlessEcho opened this issue Apr 8, 2021 · 4 comments
Closed

Two light weight and medium weight missing in variable font #190

WordlessEcho opened this issue Apr 8, 2021 · 4 comments
Labels
fixed-upstream

Comments

@WordlessEcho
Copy link

WordlessEcho commented Apr 8, 2021 •
edited
Loading

First 300 weight, second 350 weight.
image
@WordlessEcho WordlessEcho changed the title Two light weigth and medium weigth missing in variable font Two light weight and medium weight missing in variable font Apr 8, 2021
@punchcutter punchcutter mentioned this issue Apr 9, 2021
Closed
3 tasks
@twardoch
Copy link

twardoch commented Apr 9, 2021

Please explain exactly in what app & OS you’re observing this.

@WordlessEcho
Copy link
Author

Windows 10 version 19042.804
System settings -> personalization -> fonts -> Noto Sans CJK HK VF -> variable font properties

@punchcutter
Copy link
Contributor

This is because of the STAT table ranges and the way Windows builds the style names from the STAT instead of using the existing fvar named instances like pretty much every other implementation. I had the correct ranges and then accidentally changed them at the last minute and caused this. It's fixed now in the source.

punchcutter added a commit that referenced this issue Apr 28, 2021
@punchcutter
Update 2.004 sources
73f05da 
- Variable font STAT table ranges were updated to display correctly on Windows. Issues [#190](#190)
and [#291](adobe-fonts/source-han-sans#289)

- Variable font postscript names were updated to display correctly on macOS 11. Issue [#291](adobe-fonts/source-han-sans#289)

- Added missing CID+37953 to Korean Subset. Issue [#289](adobe-fonts/source-han-sans#289)

- Glyphs with missing outlines were corrected. Issue [#296](adobe-fonts/source-han-sans#296)
punchcutter added a commit that referenced this issue Apr 28, 2021
@punchcutter
Update 2.004 sources
59b0716 
- Variable font STAT table ranges were updated to display correctly on Windows. Issues [#190](#190)
and [#291](adobe-fonts/source-han-sans#289)

- Variable font postscript names were updated to display correctly on macOS 11. Issue [#291](adobe-fonts/source-han-sans#289)

- Added missing CID+37953 to Korean Subset. Issue [#289](adobe-fonts/source-han-sans#289)

- Glyphs with missing outlines were corrected. Issue [#296](adobe-fonts/source-han-sans#296)
punchcutter added a commit that referenced this issue Apr 28, 2021
@punchcutter
Update 2.004 sources
4d113c5 
- Variable font STAT table ranges were updated to display correctly on Windows. Issues [#190](#190)
and [#291](adobe-fonts/source-han-sans#289)

- Variable font postscript names were updated to display correctly on macOS 11. Issue [#291](adobe-fonts/source-han-sans#289)

- Added missing CID+37953 to Korean Subset. Issue [#289](adobe-fonts/source-han-sans#289)

- Glyphs with missing outlines were corrected. Issue [#296](adobe-fonts/source-han-sans#296)
@punchcutter
Copy link
Contributor

Fixed in 2.004.
On Windows 10 20H2 19042.631
Win10FontSettings-Variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed-upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@twardoch @punchcutter @WordlessEcho