Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1 Mastering Font checklist #3

Open
33 of 37 tasks
vv-monsalve opened this issue Jan 12, 2022 · 3 comments
Open
33 of 37 tasks

L1 Mastering Font checklist #3

vv-monsalve opened this issue Jan 12, 2022 · 3 comments
Assignees

Comments

@vv-monsalve
Copy link
Contributor

vv-monsalve commented Jan 12, 2022

L1 Mastering Font checklist

Diacritics

  • Inspect the font and choose the best version of the diacritics (in terms of balance, weight, size, contrast) and move them to comb mark.
  • Adjust left and right sidebearings of all the comb marks to 0.
  • Work on the selected diacritics to ensure the balance among all marks (contrast, weight, size, stroke or others)
  • Ensure the consistence among related marks, see issue of reference.
  • Adjust position, weight, or outlines of the diacritics if needed to, without changing the design of them, and using glyphs app locked guidelines.
  • Decomposed transformed components, review proportions ensuring round coordinates.
  • Test the comb marks by inspecting all of them in context (right-click and choose all glyphs using this component).
  • Inspect and balance the below marks (size, weight, balance) e.g. ogonek cedilla to avoid huge marks
  • Create Catalan Punt Volat
  • Delete the legacy marks and add them back so they are made from comb marks.
  • Create comb.case marks by making them less tall and less narrow while keeping them at the same weight (preferable at the height they are intended to use, to be able to inspect them in their context)
  • Create the Vietnamese mark.
  • Make compound glyphs for the entire font.
  • Adjust the anchor position.
  • Run the automatic Glyphsapp command: update glyph info.

Glyphs & Outlines

  • Create the missing glyphs needed.
  • Run the automatic Glyphsapp commands: Add extremes; cubic curves; correct outlines direction; tidy up paths; round coordinates; remove PS Hint
  • Check kerning and spacing by using the txt files. Fix any kerning and spacing errors if needed for the most common kerning pairs.
  • Check spacing and kerning for numerlas (main + .lf) and use arithmetic spacing for the .lf ones
  • Check terminal forms spacing to avoid crashes or collisions. Issue of reference
  • Run the automatic Glyphsapp command: Resolve all metrics to update the metrics in the entire font.
  • Check everything once again by going glyph by glyph.
  • Run the automatic Glyphsapp Update Glyph Info command to avoid bad names issues
  • Run the automatic Glyphsapp Convert to cubic command to avoid qcurves
  • @ ¿? ¡! ”” «» position, spacing is good
  • Lining figures based of main ones + spacing + kerning

OT Features

  • All the features that should be done automatically to be done in that way, e.g. All Letters
  • Check OpenType features and see if all listed are valid, e.g. if .fina glyphs are actually ending shapes or ss are not repeated under different names.
  • Create Lookup for positional alternates for fina and init cases
  • Inspect if Stylistic Sets have the right name or rename .001 etc... glyphs and generate the automatic OpenType code.
  • Check if there is a stylistic set that would correspond to SmallCaps feature instead and change it.
  • Check if the OpenType code has any error.
  • Hit the update & compile buttons to check everything is working well.

Testing changes

  • Inspect the font created by the CI GHA to check production errors. If the action isn't included yet in the repo, export and test the font using Glyphs.
  • Check the before and after font using gen-html diff if needed (for update font cases)
  • Check the font on gen-html proof to see if it's working well on web. Use the --imgs flag to produce images.
  • Commit and make PR using images.
@vv-monsalve
Copy link
Contributor Author

vv-monsalve commented Feb 8, 2022

Hi @Fonthausen,

After pulling the files at commit 0a18012 and creating some proof images

  • The diacritical marks are considerably higher than the point of i looking detached from the base letter. This applies also for the below marks.

Screen Shot 2022-02-08 at 16 15 53

Screen Shot 2022-02-08 at 16 31 48

  • Please also take into consideration the distance for stacked diacritics in vietnamese

  • Spacing and kerning of .lf numerals are not matching with the 'main' ones.

Screen Shot 2022-02-08 at 14 07 00

  • Please check the punctuation spacing is well balanced

Screen Shot 2022-02-08 at 14 11 44

  • micro shape needs to be adjusted.

Screen Shot 2022-02-08 at 16 25 49

  • Ligatures are using more space than the original letters

Screen Shot 2022-02-08 at 13 56 35

  • The slash in oslash looks unbalanced

Screen Shot 2022-02-08 at 13 57 26

@vv-monsalve
Copy link
Contributor Author

vv-monsalve commented Feb 16, 2022

Hi @Fonthausen, please use the latest file in the main branch to review the following

  • Diacritics consistency with the font characteristics (weight, contrast, terminal shape)

Screen Shot 2022-02-15 at 22 32 49

  • Vietnamese diacritics to use a specific anchor (e.g. topviet) so that composite glyphs could be automatically updated
  • Adjust left and right sidebearings of all the comb marks to 0. (so that they are easy to edit)

Screen Shot 2022-02-15 at 22 54 18

@Fonthausen
Copy link
Contributor

Ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants