bigquery: remove extraneous info from query result requests #2341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
callmehiphop
approved these changes
May 31, 2017
packages/bigquery/src/index.js
Outdated
| var job = options.job; | ||
|
|
||
| var requestQuery = extend({}, options); | ||
| delete requestQuery.job; | ||
|
|
||
| if (job) { | ||
| // Get results of the query. | ||
| delete requestQuery.params; | ||
| delete requestQuery.query; | ||
|
|
||
| self.request({ |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This was referenced Jul 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1503
Fixes #2337
When a user runs a query, we make two requests: 1) POST the query that starts the job, 2) GET the results from the job. If the user has a long query, step 2 will fail because the
GETrequest contains too many characters/too much information. This PR removes that extraneous information.