error-reporting: Fix an issue where authorization would fail #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `keyFilename` and `credentials` values specified in the configuration to the error-reporting library were not being used to communicate through the API. This would cause communication through the error-reporting API to fail.
googlebot
added
the
cla: yes
|
A follow-up PR will address adding regression tests. |
DominicKramer
changed the title
ofrobots
approved these changes
May 30, 2017
|
@stephenplusplus This is ready to land. |
This was referenced Jul 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
keyFilenameandcredentialsvalues specified in theconfiguration to the error-reporting library were not being
used to communicate through the API. This would cause
communication through the error-reporting API to fail.