-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for custom host with pubsub #2330
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
Thank you for this! We support this in the Datastore API, but haven't brought it over here yet, so your help is appreciated! To match what's going on in Datastore, could you rename And if you're up for it, we could use some tests as well. You can probably get by with copying what we have in Datastore: https://github.com/GoogleCloudPlatform/google-cloud-node/blob/13ec5fef0da92b74e7adf7a2479f8c1636be72d4/packages/datastore/test/index.js#L363 -- if you'd rather have me do it, no problem, just let me know. Thanks again! |
@stephenplusplus - Happily! I will do it now! Happy to contribute :-) |
It's perfect, thank you very much again! |
Honor and a pleasure :-) |
When using the emulator, I don't want to be restricted to using the environment variable of
PUBSUB_EMULATOR_HOST
- Especially when I have certain topics in the cloud and other in an emulator.This will allow the programmer to decide what host to use easily