-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: [email protected] #9343
deps: [email protected] #9343
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adds about 6KB after gzip :(
A few new rules we might want to add audits for (aria-input-field-label, aria-toggle-field-label)
do we need to disable any? (and maybe add them to #7127?)
looks like there's a smoke change needed, too
done done and done. yeah not sure what we can do about size other than put pressure on axe to trim some fat though :) |
no, not much. Custom axe bundling or something :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
sgtm! on a test URL, i saw axe taking 1350ms before and now 1050ms. sweet |
they suggest axe is twice as fast for large pages. hope that's true! |
Summary
Updates axe-core to version just released 2019-07-08.
Notable changes:
Related Issues/PRs
closes #9337, see dequelabs/axe-core#1597 (comment)