core: localize invalid URL error message #9334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
commented
Jul 8, 2019
| @@ -87,22 +87,26 @@ describe('Module Tests', function() { | |||
| }); | |||
| }); | |||
|
|
|||
| it('should throw an error when the url is invalid', function() { | |||
| return lighthouse('https:/i-am-not-valid', {}, {}) | |||
There was a problem hiding this comment.
fun fact: actually a valid URL according to the spec and implementation
brendankenny
commented
Jul 8, 2019
| }); | ||
|
|
||
| it('should throw an error when the url is invalid protocol (file:///)', function() { | ||
| return lighthouse('file:///a/fake/index.html', {}, {}) |
There was a problem hiding this comment.
I think this one was actually throwing on invalid input for the config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8944
The
INVALID_URLerror wasn't getting localized because it's thrown before enteringRunner, where errors are localized.I thought about introducing i18n into this file, but it turns out we also check the url in
Runner(when we normalize it), so this combines the checks there.The downside is extra work gets done before checking the URL and throwing, but since it was already happening (e.g. in the CLI) after launching Chrome, etc, the only extra work is creating a
Config, which is pretty fast.In addition, none of the unit tests that were supposed to be checking this were checking it. They all asserted that some error was being thrown, and it just so happens that other errors were being thrown, so the assertions were passing 🤷♀ . Fixed those.