report: only print light theme #9173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param {Function} cb | ||
| */ | ||
| _setLightThemeTemporarily(cb) { | ||
| const isDark = this._dom.find('.lh-vars', this._document).classList.contains('dark'); |
There was a problem hiding this comment.
yikes 😆 I wonder if we should use a variable or something in ReportUIFeatures state...
misread and realized this was testing classList and not textContent but a function or something that encapsulates this might be nice
|
How could a media rule unapply the is EDIT: yeah that works |
217b768 :P |
|
|
patrickhulce
approved these changes
Jun 10, 2019
There was a problem hiding this comment.
all kidding aside, I do think @hoten 's old approach would be a great candidate for the expansion business to avoid mucking up the selection state!
brendankenny
approved these changes
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9155.