report: handle underscored not_applicable scoreDisplayMode #6549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,6 +7,7 @@ | |||
|
|
|||
| const assert = require('assert'); | |||
| const Util = require('../../../../report/html/renderer/util.js'); | |||
| const sampleResult = require('../../../results/sample_v2.json'); | |||
There was a problem hiding this comment.
Maybe we should add a test of trying to render sample_v2_round_trip.json or better yet, get the no-loss-round-trip test going :)
There was a problem hiding this comment.
We should definitely do this. And maybe add another puppeteer test to make sure the report looks good. We would have caught this :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(temporarily) fixes #6540
Adds a check to
Util.prepareReportResultto convert anyscoreDisplayModeof'not_applicable'to'not-applicable'since the API is currently returning the first variant but the report renderer only understands the second.Ideally we'll fix this at the API level (or, booooo, change the official LH value to the underscored version), but this fix is easier to deploy for now.
See #6371 and #6201 for background.
cc @exterkamp @ebidel