core: make offscreen-images audit work without TTI #6039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… offscreen image audit tests.
exterkamp
changed the title
patrickhulce
suggested changes
Sep 21, 2018
lighthouse-core/test/audits/byte-efficiency/offscreen-images-test.js
Outdated
Show resolved
Hide resolved
lighthouse-core/test/audits/byte-efficiency/offscreen-images-test.js
Outdated
Show resolved
Hide resolved
…antern finding images before TTI.
lighthouse-core/test/audits/byte-efficiency/offscreen-images-test.js
Outdated
Show resolved
Hide resolved
lighthouse-core/test/audits/byte-efficiency/offscreen-images-test.js
Outdated
Show resolved
Hide resolved
patrickhulce
approved these changes
Sep 26, 2018
|
not sure what we were waiting on here :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #5955
Summary
Makes it so that when TTI derivation throws an error, the offscreen-image audit will fallback to using EndOfTab trace for cutoff instead of erroring out.