misc(logger): add time/timeEnd methods #5905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wardpeet
reviewed
Aug 24, 2018
| @@ -6,6 +6,8 @@ | |||
| 'use strict'; | |||
|
|
|||
| const debug = require('debug'); | |||
| const marky = require('marky'); | |||
brendankenny
approved these changes
Aug 24, 2018
lighthouse-logger/index.js
Outdated
|
|
||
| static timeEnd({msg, id, args=[]}, level='verbose') { | ||
| Log[level]('statusEnd', msg, ...args); | ||
| return marky.stop(id); |
There was a problem hiding this comment.
is this going to be used? Should update lighthouse-logger/index.d.ts or drop the return here?
lighthouse-logger/index.js
Outdated
| @@ -207,5 +219,10 @@ class Log { | |||
| } | |||
|
|
|||
| Log.events = new Emitter(); | |||
| Log.getEntries = _ => { | |||
There was a problem hiding this comment.
I realize this (appears) to be going for the same getEntries() name as the Performance.getEntries(), but it's definitely confusing in the context of a logger (where you might expect it to return all log entries).
WDYT about Log.getTimeEntries()?
There was a problem hiding this comment.
I had the same feeling as well, will do 👍
There was a problem hiding this comment.
settled on takeTimeEntries to mimic the semantics and name of PerfObserver 👍
wardpeet
approved these changes
Aug 24, 2018
lighthouse-logger/index.js
Outdated
| @@ -207,5 +219,10 @@ class Log { | |||
| } | |||
|
|
|||
| Log.events = new Emitter(); | |||
| Log.getEntries = _ => { | |||
There was a problem hiding this comment.
maybe make this a getter instead of a function. No big deal though
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to land #3745, we need logger to be published with the new functionality. This is just the
lighthouse-loggerportion of #3745 with a version bump to1.1.0