Skip to content
This repository has been archived by the owner on Dec 15, 2018. It is now read-only.

Add bower support #17

Open
smohadjer opened this issue Nov 23, 2015 · 11 comments
Open

Add bower support #17

smohadjer opened this issue Nov 23, 2015 · 11 comments

Comments

@smohadjer
Copy link

No description provided.

@janrembold
Copy link
Contributor

#19

@gigmaps
Copy link
Contributor

gigmaps commented Nov 30, 2015

@smohadjer bower.json was added as part of #16 - but google still needs to tag the branch master + version for the package to be able to be registered with (and therefore be installed via) bower.

There's a new pull request for google to fix this : #20 - although tags can't be added via pull request - so it's technically more a minor bug fix + comment.

For info:
If you look at https://github.com/googlemaps/js-info-bubble/releases you'll see there are no releases or tags yet for this package - the "version": "0.8" within bower.json is deprecated and not enough for bower to know which version is being installed. Bower now relies on git tags instead of version in bower.json.

See https://github.com/bower/spec/blob/master/json.md#version

@smohadjer smohadjer changed the title Add bower.json Add bower support Dec 1, 2015
@Andreas-Schoenefeldt
Copy link

+1, this would be really convenient - it would be also great, if the bower.io registry http://bower.io/search/?q=js-info-bubble was the real thing and not the fork.

@gigmaps
Copy link
Contributor

gigmaps commented Apr 19, 2016

@Andreas-Schoenefeldt i'm assuming that @daniellmb is simply squatting on the bower.io registry name until google gets their act together and tags the master release...

@markmcd @brendankenny @broady any reason why someone at google hasn't tagged the branch master + version of js-info-bubble?

@mkolmogorov
Copy link

Seems @daniellmb dropped his repository. Now there is no way to use js-info-bubble via bower

@yakovenkoroman1993
Copy link

I'm very keen to install the lib via bower too

@Andreas-Schoenefeldt
Copy link

Andreas-Schoenefeldt commented Sep 29, 2016

I actualy managed to use it via bower directly with referencing the git repository:

{
  [...]
  "dependencies": {
    "js-marker-clusterer": "https://github.com/googlemaps/js-marker-clusterer/archive/gh-pages.zip",
    "js-info-bubble": "https://github.com/googlemaps/js-info-bubble/archive/gh-pages.zip",
    [...]
  },
  "version": "0.3.1",
  "license": "MIT",
  "main": [
    "web/css/main.css",
    "web/js/main.min.js"
  ]
}

So it is possible to get this, this ticket might be good to be closed ;).

@elboletaire
Copy link

The above solution by @Andreas-Schoenefeldt stopped working right now. I've been working with js-info-bubble installed with bower for the last month without any issue and today started returning errors 500 when retrieving js-info-bubble.

Definitely I'll drop bower ASAP from all my projects. It really sucks.

@Andreas-Schoenefeldt
Copy link

Hi @elboletaire , I'm actualy not sure if my solution is realy the correct one, it might be that github has just changed the location of its code export pages.

can you try bower install [email protected]:googlemaps/js-info-bubble.git --save Alternatively you can also just create your own fork with a bower.json of this.

Best wishes
Andreas

@elboletaire
Copy link

As said, I'm not gonna use bower anymore... if I still use bower is just for old projects, but everytime we add a new package we do so with npm + gulp instead of bower.

So, thanks for your suggestion @Andreas-Schoenefeldt, but I'm not gonna give it a try.

@Andreas-Schoenefeldt
Copy link

I think all the bower tickets can be closed now - it is not working anymore and should be droped.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants