Skip to content
This repository has been archived by the owner on Apr 27, 2021. It is now read-only.

Travis test are a bit flakey... #42

Open
lesv opened this issue Sep 28, 2016 · 1 comment
Open

Travis test are a bit flakey... #42

lesv opened this issue Sep 28, 2016 · 1 comment

Comments

@lesv
Copy link
Contributor

lesv commented Sep 28, 2016

In talking w/ @tmatsuo, it turns out that the Travis tests for pubsub fail in two cases:

  1. Occasionally pubsub messages don't quite make it by the deadline
  2. Submissions from Forks don't have access to secrets.

We are considering:

  1. Deprecating the repo in favor of google-cloud
  2. fixing the tests
  3. Some limited testing for submissions from Forks.
  4. Asking the PubSub team to take over this repo.

Takashi likes 4, I like 1.

@tswast
Copy link

tswast commented Apr 5, 2017

Right now the tests are failing with

[ERROR] No plugin found for prefix 'gcloud' in the current project and in the plugin groups [org.apache.maven.plugins, org.codehaus.mojo] available from the repositories [local (/home/travis/.m2/repository), central (https://repo.maven.apache.org/maven2)] -> [Help 1]

The command "if [ -a service-account.json ]; then mvn -f appengine-push/pom.xml gcloud:deploy -Dgcloud.gcloud_directory=${HOME}/gcloud/google-cloud-sdk -Dgcloud.version=1 -DskipTests=true; fi" failed and exited with 1 during .

Which seems more than a flake. Probably the plugin is missing from the pom.xml. I've enabled nightly builds for this repo in Travis, since this repo doesn't get many PRs.

Yes, we should do 1-4. I prefer 1, so long as there is good coverage with the other samples and these are removed from the docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants