From c90241154020e54230da9ffad0dd5cdd8be4f7cb Mon Sep 17 00:00:00 2001 From: Justin Beckwith Date: Mon, 1 Feb 2021 19:26:50 -0800 Subject: [PATCH 1/2] fix: use repo metadata to populate nodejs CODEOWNERS --- .../gcp/templates/node_library/.github/CODEOWNERS | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 synthtool/gcp/templates/node_library/.github/CODEOWNERS diff --git a/synthtool/gcp/templates/node_library/.github/CODEOWNERS b/synthtool/gcp/templates/node_library/.github/CODEOWNERS new file mode 100644 index 000000000..e609ce431 --- /dev/null +++ b/synthtool/gcp/templates/node_library/.github/CODEOWNERS @@ -0,0 +1,12 @@ +# Code owners file. +# This file controls who is tagged for review for any given pull request. + +# For syntax help see: +# https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners#codeowners-syntax + +# The yoshi-nodejs team is the default owner for nodejs repositories. +{% if 'codeowner_team' in metadata['repo'] %} +* @googleapis/yoshi-nodejs {{ metadata['repo']['codeowner_team'] }} +{% else %} +* @googleapis/yoshi-nodejs +{% endif %} From a07209f333b4ff204095bd40d37b1cda3279c22a Mon Sep 17 00:00:00 2001 From: Benjamin Coe Date: Tue, 2 Feb 2021 16:22:59 -0800 Subject: [PATCH 2/2] chore: small formatting tweaks --- .../gcp/templates/node_library/.github/CODEOWNERS | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/synthtool/gcp/templates/node_library/.github/CODEOWNERS b/synthtool/gcp/templates/node_library/.github/CODEOWNERS index e609ce431..3d82ad7fe 100644 --- a/synthtool/gcp/templates/node_library/.github/CODEOWNERS +++ b/synthtool/gcp/templates/node_library/.github/CODEOWNERS @@ -1,12 +1,13 @@ # Code owners file. # This file controls who is tagged for review for any given pull request. - +# # For syntax help see: # https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners#codeowners-syntax + # The yoshi-nodejs team is the default owner for nodejs repositories. -{% if 'codeowner_team' in metadata['repo'] %} -* @googleapis/yoshi-nodejs {{ metadata['repo']['codeowner_team'] }} -{% else %} -* @googleapis/yoshi-nodejs -{% endif %} +{%- if 'codeowner_team' in metadata['repo'] %} +* @googleapis/yoshi-nodejs {{ metadata['repo']['codeowner_team'] }} +{%- else %} +* @googleapis/yoshi-nodejs +{%- endif %}