Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample README templates are incorrect for samples in client libs #663

Closed
busunkim96 opened this issue Jul 14, 2020 · 1 comment
Closed

Sample README templates are incorrect for samples in client libs #663

busunkim96 opened this issue Jul 14, 2020 · 1 comment
Assignees
@busunkim96
Labels
samples Issues that are directly related to samples. type: docs Improvement to the documentation for an API.

Comments

@busunkim96
Copy link
Contributor

See googleapis/python-pubsub@f11d069 for the manual changes that had to be made to the Pub/Sub samples

Things that need to be fixed:

  • samples assume they're in python-docs-samples
  • samples calculate the wrong relative path
  • compatible Python versions list is out of date

CC @plamut
@busunkim96 busunkim96 added the type: docs Improvement to the documentation for an API. label Jul 14, 2020
@busunkim96 busunkim96 self-assigned this Jul 14, 2020
@plamut plamut mentioned this issue Jul 15, 2020
Merged
13 tasks
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 12, 2020
@parthea parthea self-assigned this Aug 9, 2021
This was referenced Aug 9, 2021
Closed
Closed
@parthea parthea mentioned this issue Aug 30, 2021
Closed
@parthea parthea removed their assignment Jan 5, 2022
@SurferJeffAtGoogle
Copy link
Contributor

@parthea, please re-open if your changes didn't fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@busunkim96 busunkim96

Labels
samples Issues that are directly related to samples. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@parthea @busunkim96 @SurferJeffAtGoogle