This repository has been archived by the owner on May 29, 2023. It is now read-only.
fix: preserve field names in the first row #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #1087 This is still ugly, but it won't break the internal datastudio, I think.
bcoe
suggested changes
May 20, 2022
| @@ -167,10 +167,11 @@ export async function exportApisToSheets() { | |||
| const values = await getResults(); | |||
| values.unshift(['Service', 'Title', 'Group', 'HasSurface', 'InScope', 'ToS']); | |||
There was a problem hiding this comment.
won't this lead to the first column being added multiple times, since we're no longer clearing A1?
There was a problem hiding this comment.
I think it will override
bcoe
approved these changes
May 20, 2022
This was referenced May 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1087
This is still ugly, but it won't break the internal datastudio, I think.