From 02bf5fd3cbddd7481a83b063e17fa122bfbda41b Mon Sep 17 00:00:00 2001 From: Xiaozhen Liu Date: Wed, 30 Sep 2020 04:55:24 +0000 Subject: [PATCH 1/3] update bazel target name --- rules_bazel/java/java_diff_test.bzl | 2 +- .../java/com/google/api/generator/gapic/dummy/BUILD.bazel | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/rules_bazel/java/java_diff_test.bzl b/rules_bazel/java/java_diff_test.bzl index 0b3ec96168..c45e8eeb6b 100644 --- a/rules_bazel/java/java_diff_test.bzl +++ b/rules_bazel/java/java_diff_test.bzl @@ -73,7 +73,7 @@ overwritten_golden = rule( implementation = _overwritten_golden_impl, ) -def updated_golden(name, test_class_name, srcs): +def update_golden(name, test_class_name, srcs): junit_output_name = "%s_output" % name junit_output_zip( name = junit_output_name, diff --git a/src/test/java/com/google/api/generator/gapic/dummy/BUILD.bazel b/src/test/java/com/google/api/generator/gapic/dummy/BUILD.bazel index 7337d63159..40b88e0de4 100644 --- a/src/test/java/com/google/api/generator/gapic/dummy/BUILD.bazel +++ b/src/test/java/com/google/api/generator/gapic/dummy/BUILD.bazel @@ -1,4 +1,4 @@ -load("//:rules_bazel/java/java_diff_test.bzl", "updated_golden") +load("//:rules_bazel/java/java_diff_test.bzl", "update_golden") package(default_visibility = ["//visibility:public"]) @@ -28,7 +28,7 @@ TEST_CLASS_NAME = "com.google.api.generator.gapic.dummy.FileDiffInfraDummyTest" # Run `bazel run src/test/java/com/google/api/generator/gapic/dummy:FileDiffInfraDummyTest_update` # to update goldens as expected generated code. -updated_golden( +update_golden( name = "FileDiffInfraDummyTest_update", srcs = [ ":dummy_files", From 011c83e974359e5662e73f6fbfa7785c6969316a Mon Sep 17 00:00:00 2001 From: Xiaozhen Liu Date: Wed, 30 Sep 2020 18:12:59 +0000 Subject: [PATCH 2/3] rename --- rules_bazel/java/java_diff_test.bzl | 2 +- .../java/com/google/api/generator/gapic/dummy/BUILD.bazel | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/rules_bazel/java/java_diff_test.bzl b/rules_bazel/java/java_diff_test.bzl index c45e8eeb6b..08ce5ebf5f 100644 --- a/rules_bazel/java/java_diff_test.bzl +++ b/rules_bazel/java/java_diff_test.bzl @@ -73,7 +73,7 @@ overwritten_golden = rule( implementation = _overwritten_golden_impl, ) -def update_golden(name, test_class_name, srcs): +def golden_update(name, test_class_name, srcs): junit_output_name = "%s_output" % name junit_output_zip( name = junit_output_name, diff --git a/src/test/java/com/google/api/generator/gapic/dummy/BUILD.bazel b/src/test/java/com/google/api/generator/gapic/dummy/BUILD.bazel index 40b88e0de4..3caa66fb99 100644 --- a/src/test/java/com/google/api/generator/gapic/dummy/BUILD.bazel +++ b/src/test/java/com/google/api/generator/gapic/dummy/BUILD.bazel @@ -1,4 +1,4 @@ -load("//:rules_bazel/java/java_diff_test.bzl", "update_golden") +load("//:rules_bazel/java/java_diff_test.bzl", "golden_update") package(default_visibility = ["//visibility:public"]) @@ -28,7 +28,7 @@ TEST_CLASS_NAME = "com.google.api.generator.gapic.dummy.FileDiffInfraDummyTest" # Run `bazel run src/test/java/com/google/api/generator/gapic/dummy:FileDiffInfraDummyTest_update` # to update goldens as expected generated code. -update_golden( +golden_update( name = "FileDiffInfraDummyTest_update", srcs = [ ":dummy_files", From 6ab7e9b89a9a6f117047e587c2dbbcbc418e5eeb Mon Sep 17 00:00:00 2001 From: Xiaozhen Liu Date: Thu, 1 Oct 2020 06:35:24 +0000 Subject: [PATCH 3/3] fix --- src/test/java/com/google/api/generator/engine/BUILD.bazel | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/test/java/com/google/api/generator/engine/BUILD.bazel b/src/test/java/com/google/api/generator/engine/BUILD.bazel index 90bd694347..1bcbd20f5f 100644 --- a/src/test/java/com/google/api/generator/engine/BUILD.bazel +++ b/src/test/java/com/google/api/generator/engine/BUILD.bazel @@ -1,4 +1,4 @@ -load("//:rules_bazel/java/java_diff_test.bzl", "updated_golden") +load("//:rules_bazel/java/java_diff_test.bzl", "golden_update") package(default_visibility = ["//visibility:public"]) @@ -32,7 +32,7 @@ TEST_CLASS_NAME = "com.google.api.generator.engine.JavaCodeGeneratorTest" # Run `bazel run src/test/java/com/google/api/generator/engine:JavaCodeGeneratorTest_update` # to update goldens as expected generated code. -updated_golden( +golden_update( name = "JavaCodeGeneratorTest_update", srcs = [ ":engine_files",