Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmanaged dependency checks failing at shared-resourcemapping #3096

Open
suztomo opened this issue Aug 12, 2024 · 4 comments
Open

Unmanaged dependency checks failing at shared-resourcemapping #3096

suztomo opened this issue Aug 12, 2024 · 4 comments
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@suztomo
Copy link
Member

suztomo commented Aug 12, 2024

"Unmanaged dependency check / unmanaged_dependency_check (pull_request)" checks are failing.

E.g., googleapis/java-storage-nio#1449

https://github.com/googleapis/java-storage-nio/actions/runs/10304713767/job/28523846932?pr=1449

Run bom_absolute_path=$(realpath "google-cloud-nio-bom/pom.xml")
Running Unmanaged Dependency Check against /home/runner/work/java-storage-nio/java-storage-nio/google-cloud-nio-bom/pom.xml
This pull request seems to add new third-party dependency, [com.google.cloud.opentelemetry:shared-resourcemapping, com.google.cloud.opentelemetry:exporter-metrics], among the artifacts listed in google-cloud-nio-bom/pom.xml.
@suztomo
Copy link
Member Author

suztomo commented Aug 12, 2024

They come from java-storage dependency: https://gist.github.com/suztomo/90f007ffd41153c1529902d36f20bafb

@suztomo suztomo self-assigned this Aug 12, 2024
@suztomo
Copy link
Member Author

suztomo commented Aug 12, 2024

~/java-storage $ mvn -pl google-cloud-storage  dependency:tree
...
[INFO] com.google.cloud:google-cloud-storage:jar:2.41.0
...
[INFO] +- com.google.cloud.opentelemetry:exporter-metrics:jar:0.31.0:compile
[INFO] |  +- org.slf4j:slf4j-api:jar:2.0.9:compile
[INFO] |  +- com.google.cloud:google-cloud-monitoring:jar:3.31.0:compile
[INFO] |  |  \- com.google.api.grpc:proto-google-cloud-monitoring-v3:jar:3.31.0:compile
[INFO] |  \- com.google.cloud.opentelemetry:shared-resourcemapping:jar:0.31.0:runtime

@suztomo
Copy link
Member Author

suztomo commented Aug 12, 2024

It seems it was googleapis/java-storage#2590 that broke the check (the previous pull request googleapis/java-storage#2652 was green).

image

googleapis/java-storage#2590 (comment) Ben wrote:

Ideally all of the otel version come from shared dependencies.

I'll follow up on this.

@suztomo
Copy link
Member Author

suztomo commented Aug 12, 2024

Jesse has created b/356675340.

@diegomarquezp diegomarquezp added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants