Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hermetic Build integration tests fail when googleapis have proto changes not yet reflected in google-cloud-java or googleapis-gen #2303

Closed
diegomarquezp opened this issue Dec 13, 2023 · 4 comments
Closed

Hermetic Build integration tests fail when googleapis have proto changes not yet reflected in google-cloud-java or googleapis-gen #2303

diegomarquezp opened this issue Dec 13, 2023 · 4 comments
Labels
hermetic-build priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@diegomarquezp
Copy link
Contributor

Changes in googleapis take a while to reflect in google-cloud-java (owlbot) and googleapis-gen (bazelbot).
Our hermetic build IT builds from the latest commit of googleapis and then compares to google-cloud-java or googleapis-gen, which may be outdated at the moment of running them.

The only workaround is to wait for the bots atm.
@diegomarquezp diegomarquezp added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. hermetic-build labels Dec 13, 2023
@diegomarquezp
Copy link
Contributor Author

cc: @JoeWang1127

@diegomarquezp diegomarquezp mentioned this issue Dec 13, 2023
Merged
@diegomarquezp diegomarquezp changed the title Hermetic Build integration tests fail when googleapis have proto changes not yet reflected in google-cloud-java Hermetic Build integration tests fail when googleapis have proto changes not yet reflected in google-cloud-java nor googleapis-gen Dec 14, 2023
@diegomarquezp
Copy link
Contributor Author

diegomarquezp commented Jan 2, 2024 •
edited
Loading

googleapis/google-cloud-java#10138 should fix the failing asset test
Edit: it was fixed temporarily but then an update to gapic-generator-java 2.31.0 made the ITs to stall again

@diegomarquezp diegomarquezp mentioned this issue Jan 9, 2024
Merged
@diegomarquezp diegomarquezp changed the title Hermetic Build integration tests fail when googleapis have proto changes not yet reflected in google-cloud-java nor googleapis-gen Hermetic Build integration tests fail when googleapis have proto changes not yet reflected in google-cloud-java or googleapis-gen Jan 9, 2024
@alicejli
Copy link
Contributor

alicejli commented Apr 2, 2024

@diegomarquezp is this still an issue?

@diegomarquezp
Copy link
Contributor Author

@alicejli, thanks for bringing it up. We now use special branches for the ITs, so we don't fall into this issue anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hermetic-build priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@diegomarquezp @alicejli