-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: skip generating grpc-*
directory if transport is rest
#1979
Conversation
grpc-*
directory if transport is rest
grpc-*
directory if transport is rest
grpc-*
directory if transport is rest
grpc-*
directory if transport is rest
grpc-*
directory if transport is rest
Test locally with google compute, a rest only library. Will add more integration tests in another PR. |
@JoeWang1127 There seems to be a lot more going on here than just "skip generating grpc-* directory if transport is rest". Can you explain more what you're trying to do in this PR or split it into multiple? It will be easier to review. |
I added a PR description. The refactor happens here because the utilitiy functions that parsing |
[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed! |
[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed! |
[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed! |
grpc-*
directory if transport is rest
grpc-*
directory if transport is rest
In this PR:
grpc-*
directory when transport isrest
#1981transport
can only be parsed asgrpc+rest
orgrpc
.transport
,rest_numeric_enums
andinclude_samples
and add unit tests.