Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monorepo migration breaks the pre-commit mvn test step #1270

Closed
burkedavison opened this issue Jan 24, 2023 · 3 comments · Fixed by #1294
Closed

Monorepo migration breaks the pre-commit mvn test step #1270

burkedavison opened this issue Jan 24, 2023 · 3 comments · Fixed by #1294
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@burkedavison
Copy link
Member

Although #1253 has been resolved, the mvn test step is now failing.

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile (default-compile) on project gapic-generator-java: Compilation failure: Compilation failure: 
[ERROR] /gapic-generator-java/gapic-generator-java/src/main/java/com/google/api/generator/gapic/composer/rest/ServiceClientTestClassComposer.java:[19,43] package com.google.api.gax.httpjson.testing does not exist
[ERROR] /gapic-generator-java/gapic-generator-java/src/main/java/com/google/api/generator/gapic/composer/rest/ServiceClientTestClassComposer.java:[24,38] package com.google.api.gax.rpc.testing does not exist
[ERROR] /gapic-generator-java/gapic-generator-java/src/main/java/com/google/api/generator/gapic/composer/grpc/ServiceClientTestClassComposer.java:[18,39] package com.google.api.gax.grpc.testing does not exist
[ERROR] /gapic-generator-java/gapic-generator-java/src/main/java/com/google/api/generator/gapic/composer/grpc/ServiceClientTestClassComposer.java:[19,39] package com.google.api.gax.grpc.testing does not exist
[ERROR] /gapic-generator-java/gapic-generator-java/src/main/java/com/google/api/generator/gapic/composer/grpc/ServiceClientTestClassComposer.java:[20,39] package com.google.api.gax.grpc.testing does not exist
[ERROR] /gapic-generator-java/gapic-generator-java/src/main/java/com/google/api/generator/gapic/composer/grpc/ServiceClientTestClassComposer.java:[21,39] package com.google.api.gax.grpc.testing does not exist

Attempting to fix this also unveils further issues with the next bazel integration test invocation.

@burkedavison burkedavison added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jan 24, 2023
@blakeli0
Copy link
Collaborator

Thanks Burke. I discussed this with a few folks as well, I personally don't rely on pre-commit but some folks are still using it, fixing pre-commit is on my TODO list. For now, you can always manually run unit tests and integration tests.

@lqiu96
Copy link
Contributor

lqiu96 commented Jan 25, 2023

I think this is related to #1144 -- I think the temp workaround (which doesn't solve the mvn test issue at the root) is to cd into each module and run mvn test when needed.

@suztomo
Copy link
Member

suztomo commented Feb 1, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants