Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-trigger: The bot did not mark the release as published or successful #4978

Closed
Neenu1995 opened this issue Feb 14, 2023 · 2 comments
Closed
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@Neenu1995
Copy link
Contributor

Triggered a release from java-bigquerystorage. The release job was triggered by the bot. It was successful but the bot did not report it back in the PR.

@Neenu1995 Neenu1995 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Feb 14, 2023
@chingor13
Copy link
Contributor

It's currently the release job's duty to report pass/fail status back to the PR. Unfortunately, the release-trigger bot does not have access to the release job status.

From the logs:

Traceback (most recent call last):
  File "/root/.pyenv/versions/3.9.13/lib/python3.9/runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/root/.pyenv/versions/3.9.13/lib/python3.9/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/root/.pyenv/versions/3.9.13/lib/python3.9/site-packages/releasetool/__main__.py", line 213, in <module>
    main()
  File "/root/.pyenv/versions/3.9.13/lib/python3.9/site-packages/click/core.py", line 1128, in __call__
    return self.main(*args, **kwargs)
  File "/root/.pyenv/versions/3.9.13/lib/python3.9/site-packages/click/core.py", line 1053, in main
    rv = self.invoke(ctx)
  File "/root/.pyenv/versions/3.9.13/lib/python3.9/site-packages/click/core.py", line 1659, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/root/.pyenv/versions/3.9.13/lib/python3.9/site-packages/click/core.py", line 1395, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/root/.pyenv/versions/3.9.13/lib/python3.9/site-packages/click/core.py", line 754, in invoke
    return __callback(*args, **kwargs)
  File "/root/.pyenv/versions/3.9.13/lib/python3.9/site-packages/releasetool/__main__.py", line 193, in publish_reporter_finish
    releasetool.commands.publish_reporter.finish(github_token, pr, status, details)
  File "/root/.pyenv/versions/3.9.13/lib/python3.9/site-packages/releasetool/commands/publish_reporter.py", line 131, in finish
    github_token = releasetool.github.GitHubToken.token_from_dict(
  File "/root/.pyenv/versions/3.9.13/lib/python3.9/site-packages/releasetool/github.py", line 83, in token_from_dict
    access_token = get_installation_access_token(
  File "/root/.pyenv/versions/3.9.13/lib/python3.9/site-packages/releasetool/github.py", line 106, in get_installation_access_token
    private_key = default_backend().load_pem_private_key(private_key_bytes, None)
TypeError: load_pem_private_key() missing 1 required positional argument: 'unsafe_skip_rsa_key_validation'

I think there's a breaking change from python's cryptography package from v38 -> v39 which may have been merged in your repo.

@chingor13
Copy link
Contributor

Please update your releasetool version to 1.10.5 to fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants