-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-please: Release please is ignoring commits in multi-commit owlbot PRs #3220
Comments
The only solution I have found for this issue is to use the |
When merging a PR the content looks like this if it's not manually cleaned up:
This is by virtue of how GitHub handles multiple commits in a PR. If you manually cleanup the commit message when merging, so that it looks like this:
Then it will be parsed appropriately. The problem is the additional newlines GitHub adds, and the |
As @bcoe explains, this is behaving exactly according to spec. We intentionally do not parse the default squash/merge commit format because usually if you are squash merging, you do not want all the intermediate commit messages to appear in the changelog. When you are manually merging a commit, the onus is on the maintainer to correctly format the commit message. If you do err when merging, you can override the message using: https://github.com/googleapis/release-please#how-can-i-fix-release-notes |
Owlbot behaviour changed recently to add multiple commit to the same PR as opposed to multiple PRs. This appends multiple commits with their contexts in the PR body. Release-please used to pick up all commit messages with conventional commit prefix(feat, fix, deps etc) and add it to the release notes in release PR. Now it is only picking the commit message in the title and not in the body.
Example PR: googleapis/java-common-protos#322
Proposed release PR only has the title commit.
Example release PR: googleapis/java-common-protos#326
The text was updated successfully, but these errors were encountered: