getDefaultComponent doesn't find the right packageName if includeComponentInTag is set to false and it is for a nested path

[sofisl]

I was investigating why release-please did not open a PR here: googleapis/gax-nodejs#1553

The CLI does not tag the PR with the warning:

⚠ PR component: undefined does not match configured component: google-gax
(here):

release-please/src/strategies/base.ts

Line 615 in 72b0ab3

PR component: ${branchName.component} does not match configured component: ${branchComponent}
That is true, since the branch does not contain the component:

There's a bug that occurs when setting the branchName in buildPullRequests in manifest, it will return empty here

I think that's because getBranchComponent returns an empty string here:

release-please/src/strategies/base.ts

Line 176 in 72b0ab3

return this.component || (await this.getDefaultComponent());

because getDefaultComponent is not grabbing the packageName correctly for nested packages that have includeComponentInTag set to false (as in my config)

A workaround I'll try in the meantime is just to specify it in the config object explicitly - that should work. But I think the better functionality is to automatically grab it from the nearest package.json

[sofisl]

see: googleapis/gax-nodejs#1555

[jurijzahn8019]

Hi,

same behaviour with this config:
Somehow nothing helps.

After PR merge it does not gets released

{
  "packages": {
    ".": {
      "include-component-in-tag": false,
      "package-name": "verint-xmsdk"
    }
  },
  "separate-pull-requests": false,
  "pull-request-title-pattern": "chore${scope}: release ${component} ${version}",
  "group-pull-request-title-pattern": "chore${scope}: release ${component} ${version}",
  "changelog-path": "CHANGELOG.md",
  "bump-minor-pre-major": true,
  "bump-patch-for-minor-pre-major": true,
  "draft": false,
  "prerelease": false,
  "release-type": "node",
  "label": "release: pending :hourglass:",
  "release-label": "release: tagged :ship:",
  "$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json"
}

Here Some Logs

Running release-please version: 16.5.0
❯ Fetching release-please-config.json from branch main
❯ Fetching .release-please-manifest.json from branch main
✔ Building releases
✔ Building strategies by path
❯ .: node
❯ Found pull request #242: 'chore(main): release  1.16.0'
✔ Building release for path: .
❯ type: node
❯ targetBranch: main
⚠ PR component: undefined does not match configured component: verint-xmsdk
❯ Fetching release-please-config.json from branch main
❯ Fetching .release-please-manifest.json from branch main
✔ Building pull requests
✔ Building strategies by path
❯ .: node
✔ Collecting release commit SHAs
❯ release search depth: 400

[jurijzahn8019]

I have fired it out:

setting separate-pull-requests: true does the trick