Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: opam support for project.opam.locked files #1325

Merged
merged 2 commits into from
Mar 8, 2022

Conversation

erikmd
Copy link
Contributor

@erikmd erikmd commented Mar 5, 2022

Checklist:

Fixes #1085

@erikmd erikmd requested a review from a team as a code owner March 5, 2022 15:11
@erikmd erikmd requested a review from a team March 5, 2022 15:11
erikmd added a commit to ocaml-sf/learn-ocaml that referenced this pull request Mar 6, 2022
erikmd added a commit to ocaml-sf/learn-ocaml that referenced this pull request Mar 6, 2022
@erikmd
Copy link
Contributor Author

erikmd commented Mar 7, 2022

Sorry for the whitespace linting issues… I'll push a new version that fixes these.

(and let me know if ever you think some other refactoring would be required − as I'm not fluent in Node.js)

Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chingor13 chingor13 merged commit 858199e into googleapis:main Mar 8, 2022
@erikmd erikmd deleted the opam-support branch March 8, 2022 17:54
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 8, 2022
🤖 I have created a release *beep* *boop*
---


## [13.5.0](v13.4.15...v13.5.0) (2022-03-08)


### Features

* **ocaml:** update opam `project.opam.locked` files ([#1325](#1325)) ([858199e](858199e))


### Bug Fixes

* fix regex for parsing major version update ([#1330](#1330)) ([afadec9](afadec9))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
yurug pushed a commit to ocaml-sf/learn-ocaml that referenced this pull request Mar 9, 2022
* chore: release 0.14.0

* chore: Update `*.opam.locked` as well

Waiting-for: googleapis/release-please#1325

* chore(CHANGELOG.md): Add missing item

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Erik Martin-Dorel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: opam support currently doesn't update project.opam.locked files
2 participants