Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix c.g.c structure #982

Merged
merged 2 commits into from
Feb 1, 2023
Merged

docs: fix c.g.c structure #982

merged 2 commits into from
Feb 1, 2023

Conversation

dandhlee
Copy link
Contributor

@dandhlee dandhlee commented Feb 1, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Making rearrangements to better structure the Storage docs. Googlers see bug below for staged view.

Fixes b/267341907 🦕

@dandhlee dandhlee requested review from a team as code owners February 1, 2023 10:59
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/python-storage API. labels Feb 1, 2023
@dandhlee dandhlee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 1, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 1, 2023
@cojenco cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 1, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 1, 2023
cojenco
cojenco reviewed Feb 1, 2023
View reviewed changes
docs/acl_guide.rst
@@ -0,0 +1,82 @@
ACL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the structure and moving the guides up. With this update, I plan to modify this guide to include both ACL and IAM. I'll create a separate PR once this is merged in :)

docs/index.rst Show resolved Hide resolved
cojenco
cojenco approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Dan!

@dandhlee
Copy link
Contributor Author

dandhlee commented Feb 1, 2023

Sample issue has been looked into and will be dealt in a separate PR.

@dandhlee dandhlee merged commit d5a2931 into main Feb 1, 2023
@dandhlee dandhlee deleted the fix_structure branch February 1, 2023 20:44
@release-please release-please bot mentioned this pull request Feb 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cojenco cojenco cojenco approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/python-storage API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dandhlee @cojenco @yoshi-kokoro