-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable delete_blobs() to preserve generation #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
Pull request size is small.
api: storage
Issues related to the googleapis/python-storage API.
labels
Aug 10, 2022
Looks good, but can we additionally update the docstring to mention that the default behavior is to drop the generation? That way preserve_generation makes sense in context. |
product-auto-label
bot
added
size: m
Pull request size is medium.
and removed
size: s
Pull request size is small.
labels
Aug 11, 2022
Great idea, I've noted the default behavior in the docstring |
andrewsg
requested changes
Aug 15, 2022
cojenco
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Aug 16, 2022
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Aug 16, 2022
andrewsg
approved these changes
Aug 23, 2022
cojenco
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Aug 23, 2022
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Aug 23, 2022
cojenco
added
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Aug 23, 2022
gcf-merge-on-green
bot
removed
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: storage
Issues related to the googleapis/python-storage API.
size: m
Pull request size is medium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a flag
preserve_generation
to the methodbucket.delete_blobs()
delete_blobs()
andbucket.delete(force=True)
Fixes #814