Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect example for lifecycle_rules #832

Closed
bmccutchon opened this issue Aug 4, 2022 · 1 comment · Fixed by #841
Closed

Incorrect example for lifecycle_rules #832

bmccutchon opened this issue Aug 4, 2022 · 1 comment · Fixed by #841
Assignees
@andrewsg
Labels
api: storage Issues related to the googleapis/python-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@bmccutchon
Copy link

The "note" on Bucket.lifecycle_rules acts as if lifecycle_rules returns a list, but it actually returns a generator.
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Aug 4, 2022
@andrewsg andrewsg self-assigned this Aug 5, 2022
@andrewsg andrewsg added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Aug 5, 2022
@andrewsg andrewsg mentioned this issue Aug 11, 2022
Merged
@andrewsg
Copy link
Contributor

Fixing the docstring on this now; I'd like to actually make it consistent with the setter (returning a list) or use some other consistent interface, but can't without breaking backwards compatibility, so this is now on the list for 2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewsg andrewsg

Labels
api: storage Issues related to the googleapis/python-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: Update docstring for lifecycle_rules to match generator behavior googleapis/python-storage
2 participants
@andrewsg @bmccutchon