feat: add support for updateDatabase in Cloud Spanner #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
grace223
approved these changes
Mar 18, 2023
| @@ -29,6 +29,7 @@ | |||
| from google.api_core import gapic_v1 | |||
| from google.iam.v1 import iam_policy_pb2 | |||
| from google.iam.v1 import options_pb2 | |||
| from google.protobuf.field_mask_pb2 import FieldMask | |||
|
|
|||
| from google.cloud.spanner_admin_database_v1 import CreateDatabaseRequest | |||
| @@ -17,8 +17,10 @@ | |||
|
|
|||
| import mock | |||
| from google.api_core import gapic_v1 | |||
| from google.cloud.spanner_admin_database_v1 import Database as DatabasePB | |||
| from google.cloud.spanner_v1.param_types import INT64 | |||
product-auto-label
bot
added
size: l
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
aayushimalik
force-pushed
the
drop-database-protection
branch
from
9ca2103
to
e4163d0
Compare
product-auto-label
bot
added
size: m
rajatbhatta
reviewed
Apr 4, 2023
rajatbhatta
changed the title
asthamohta
reviewed
Apr 4, 2023
asthamohta
reviewed
Apr 4, 2023
asthamohta
reviewed
Apr 21, 2023
| @@ -155,6 +160,8 @@ def __init__( | |||
| self._encryption_config = encryption_config | |||
| self._database_dialect = database_dialect | |||
| self._database_role = database_role | |||
| self._enable_drop_protection = enable_drop_protection | |||
| self._reconciling = False | |||
There was a problem hiding this comment.
I can't see any place where this value is updated?
There was a problem hiding this comment.
This is updated at line 359 of this file, using the property setter.
There was a problem hiding this comment.
I am referring to reconciling
asthamohta
reviewed
Apr 21, 2023
asthamohta
reviewed
Apr 21, 2023
asthamohta
added
the
do not merge
asthamohta
approved these changes
Apr 26, 2023
…p-database-protection # Conflicts: # google/cloud/spanner_v1/database.py
rajatbhatta
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
rajatbhatta
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
rajatbhatta
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
Added samples from #917 to here (for single merge). Both PRs are approved. |
rajatbhatta
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
rajatbhatta
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.