Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support JSON object consisting of an array. #782

Merged
merged 4 commits into from
Aug 17, 2022
Merged

feat: support JSON object consisting of an array. #782

merged 4 commits into from
Aug 17, 2022

Conversation

IlyaFaer
Copy link
Contributor

No description provided.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/python-spanner API. labels Aug 12, 2022
@IlyaFaer IlyaFaer marked this pull request as ready for review August 12, 2022 09:43
@IlyaFaer IlyaFaer requested review from a team as code owners August 12, 2022 09:43
@IlyaFaer
Copy link
Contributor Author

@asthamohta, okay, JSON-array seems to be working fine with these changes.

@asthamohta
Copy link
Contributor

Hi Ilya, can you also add a test case in system/test_session_api.py
https://github.com/googleapis/python-spanner/blob/main/tests/system/test_session_api.py#L142
We can add another json value in the array and check if it is fetched correctly:
[
{"name": "room 1", "open": True},
{"name": "room 2", "open": False},
]

@asthamohta asthamohta linked an issue Aug 16, 2022 that may be closed by this pull request
Issue in the Spanner Python client when an array value is present at the top-level of a JSON column #716
Closed
@asthamohta asthamohta mentioned this pull request Aug 16, 2022
Closed
@asthamohta asthamohta added the automerge Merge the pull request once unit tests and other checks pass. label Aug 17, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 92a3169 into googleapis:main Aug 17, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 17, 2022
@release-please release-please bot mentioned this pull request Aug 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asthamohta asthamohta asthamohta approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue in the Spanner Python client when an array value is present at the top-level of a JSON column
3 participants
@IlyaFaer @asthamohta @parthea