Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for Postgresql dialect #741

Merged
merged 27 commits into from
Jun 17, 2022
Merged

feat: Add support for Postgresql dialect #741

merged 27 commits into from
Jun 17, 2022

Conversation

ansh0l
Copy link
Contributor

@ansh0l ansh0l commented Jun 6, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ansh0l ansh0l requested a review from asthamohta June 6, 2022 07:18
@ansh0l ansh0l requested review from a team as code owners June 6, 2022 07:18
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/python-spanner API. labels Jun 6, 2022
@ansh0l ansh0l added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 6, 2022
IlyaFaer
IlyaFaer reviewed Jun 6, 2022
View reviewed changes
google/cloud/spanner_admin_database_v1/types/backup.py Outdated Show resolved Hide resolved
google/cloud/spanner_v1/instance.py Outdated Show resolved Hide resolved
tests/system/test_dbapi.py Outdated Show resolved Hide resolved
asthamohta
asthamohta reviewed Jun 7, 2022
View reviewed changes
tests/system/conftest.py Outdated Show resolved Hide resolved
asthamohta
asthamohta reviewed Jun 7, 2022
View reviewed changes
tests/_fixtures.py Outdated Show resolved Hide resolved
@asthamohta
Copy link
Contributor

image
From the number of tests run, it looks like PG tests did not run at all

@ansh0l
Copy link
Contributor Author

ansh0l commented Jun 11, 2022

Regarding From the number of tests run, it looks like PG tests did not run at all -> Additional tests are being run, confirmed in meet session.

@ansh0l ansh0l removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 13, 2022
asthamohta
asthamohta reviewed Jun 15, 2022
View reviewed changes
google/cloud/spanner_v1/types/transaction.py
@@ -30,7 +30,7 @@


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is unrelated, can you checkout this file?

@ansh0l ansh0l added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Jun 15, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 15, 2022
@ansh0l
Copy link
Contributor Author

ansh0l commented Jun 15, 2022

adding automerge since kokoro build is successful. But others are stuck.

@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 16, 2022
@ansh0l ansh0l added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Jun 16, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 16, 2022
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 16, 2022
@ansh0l ansh0l merged commit d2551b0 into googleapis:main Jun 17, 2022
@release-please release-please bot mentioned this pull request Jun 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IlyaFaer IlyaFaer IlyaFaer left review comments

@asthamohta asthamohta asthamohta approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ansh0l @asthamohta @IlyaFaer @yoshi-kokoro @larkee