Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a py.typed file for submodule #625

Closed
crwilcox opened this issue Oct 12, 2021 · 1 comment
Closed

Add a py.typed file for submodule #625

crwilcox opened this issue Oct 12, 2021 · 1 comment
Assignees
Labels
api: spanner Issues related to the googleapis/python-spanner API. type: process A process-related concern. May include testing, release, or the like.

Comments

@crwilcox
Copy link
Contributor

To be in accordance with PEP 561 we should add a py.typed file to google/cloud/datastore/py.typed

The file can be empty but does need to be present for some type checkers.

Also, for this to work, google/cloud/spanner.py needs to be restructured to google/cloud/spanner/init.py

See googleapis/python-firestore#447 for additional context

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Oct 12, 2021
@crwilcox
Copy link
Contributor Author

crwilcox commented Oct 13, 2021

Do note, you may need to run mypy, pyright, pytype against our samples before merging. It will ensure that we aren't exposing users to failing type checks.

Ideally we would add this to CI as well, to avoid future breakage.

@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Nov 3, 2021
@IlyaFaer IlyaFaer added type: process A process-related concern. May include testing, release, or the like. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

No branches or pull requests

5 participants