Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc-interceptor is listed as a dependency but is only used for testing utilities #1143

Closed
asottile-sentry opened this issue May 23, 2024 · 0 comments · Fixed by #1158
Closed
Assignees
Labels
api: spanner Issues related to the googleapis/python-spanner API.

Comments

@asottile-sentry
Copy link
Contributor

Environment details

N/A - latest

Steps to reproduce

this is the only usage:

from grpc_interceptor import ClientInterceptor

it should be an optional dependency and not in install_requires:

"grpc-interceptor >= 0.15.4",

perhaps an extras_require named testing ?

Code example

N/A

Stack trace

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner API.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants