Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log when a new stream_ack_deadline_seconds is sent on the StreamingPull BiDi stream #689

Closed
pradn opened this issue May 26, 2022 · 1 comment · Fixed by #692 or #693
Closed

Log when a new stream_ack_deadline_seconds is sent on the StreamingPull BiDi stream #689

pradn opened this issue May 26, 2022 · 1 comment · Fixed by #692 or #693
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@pradn
Copy link
Contributor

pradn commented May 26, 2022

We can do an info-level log whenever the value changes:

It may help debug issues. More generally, we might want to log changes in critical parameters like changes in the ack deadline (which depends on recent delivery-to-ack durations).

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label May 26, 2022
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label May 27, 2022
@acocuzzo acocuzzo added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label May 27, 2022
@acocuzzo
Copy link
Contributor

acocuzzo commented May 27, 2022

We do also have debug logs for the current deadline value:

            deadline = self._manager._obtain_ack_deadline(maybe_update=True)
            _LOGGER.debug("The current deadline value is %d seconds.", deadline)

in the leaser.py.

@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
3 participants