Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Handle duplicate acks with streaming pull #662

Merged
merged 43 commits into from
May 11, 2022
Merged

Fix: Handle duplicate acks with streaming pull #662

merged 43 commits into from
May 11, 2022

Conversation

acocuzzo
Copy link
Contributor

@acocuzzo acocuzzo commented Apr 19, 2022 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #661 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: pubsub Issues related to the googleapis/python-pubsub API. labels Apr 19, 2022
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Apr 20, 2022
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Apr 20, 2022
@acocuzzo acocuzzo changed the title Duplicate ack handling fix: Duplicate ack handling Apr 20, 2022
@acocuzzo acocuzzo changed the title fix: Duplicate ack handling Fix: Handle duplicate ackswith streaming pull Apr 20, 2022
@acocuzzo acocuzzo changed the title Fix: Handle duplicate ackswith streaming pull Fix: Handle duplicate acks with streaming pull Apr 20, 2022
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Apr 21, 2022
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Apr 21, 2022
@acocuzzo acocuzzo requested a review from a team as a code owner April 22, 2022 19:27
@acocuzzo acocuzzo requested a review from loferris April 22, 2022 19:27
@pradn pradn mentioned this pull request Apr 27, 2022
Closed
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels May 4, 2022
pradn
pradn approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@pradn pradn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more comment and we're done. Thank you!

tests/unit/pubsub_v1/subscriber/test_dispatcher.py Outdated Show resolved Hide resolved
@acocuzzo acocuzzo merged commit 219491e into googleapis:main May 11, 2022
@release-please release-please bot mentioned this pull request May 11, 2022
Merged
@release-please release-please bot mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradn pradn pradn approved these changes

@loferris loferris Awaiting requested review from loferris loferris was automatically assigned from googleapis/python-samples-owners

Assignees

@pradn pradn

Labels
api: pubsub Issues related to the googleapis/python-pubsub API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assert fails with duplicate AckRequests
3 participants
@acocuzzo @pradn @yoshi-kokoro