Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mypy errors #622

Merged
merged 8 commits into from
Mar 23, 2022
Merged

fix: mypy errors #622

merged 8 commits into from
Mar 23, 2022

Conversation

acocuzzo
Copy link
Contributor

@acocuzzo acocuzzo commented Mar 22, 2022 •
edited
Loading

Adds checks for future is None and replaces containers.ScalarMap with Dict[type,type] in streaming_pull_manager.

Fixes #620 🦕

@acocuzzo acocuzzo requested review from a team as code owners March 22, 2022 02:53
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Mar 22, 2022
anguillanneuf
anguillanneuf suggested changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update test for google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py to bring coverage back to 100%.

pradn
pradn requested changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@pradn pradn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised we're getting mypy errors after these changes passed the mypy presubmit kokoro. I wonder if mypy its was changed or if we are running a newer version.

google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py Outdated Show resolved Hide resolved
google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py Outdated Show resolved Hide resolved
google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py Outdated Show resolved Hide resolved
google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py Outdated Show resolved Hide resolved
google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py Outdated Show resolved Hide resolved
anguillanneuf
anguillanneuf approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @acocuzzo!

@anguillanneuf anguillanneuf merged commit dab13d5 into googleapis:main Mar 23, 2022
@release-please release-please bot mentioned this pull request Mar 23, 2022
Closed
@anguillanneuf anguillanneuf mentioned this pull request Mar 23, 2022
Merged
@release-please release-please bot mentioned this pull request Apr 6, 2022
Merged
@Tonow Tonow mentioned this pull request May 23, 2022
Closed
@release-please release-please bot mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anguillanneuf anguillanneuf anguillanneuf approved these changes

@pradn pradn pradn approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/python-pubsub API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

my/py failures on streaming_pull_manager
3 participants
@acocuzzo @pradn @anguillanneuf