Auto generated code get_distribution method through DistributionNotFound error

[HemangChothani]

Try statement never executed because of get_distribution(google-pubsub), it should be get_distribution("google-cloud-pubsub",)

python-pubsub/google/pubsub_v1/services/publisher/transports/base.py

Lines 34 to 37 in 6b9eec8

	try:
	DEFAULT_CLIENT_INFO = gapic_v1.client_info.ClientInfo(
	gapic_version=pkg_resources.get_distribution("google-pubsub",).version,
	)

also found same thing at various places:

python-pubsub/google/pubsub_v1/services/subscriber/transports/base.py

Line 36 in 6b9eec8

gapic_version=pkg_resources.get_distribution("google-pubsub",).version,

python-pubsub/google/pubsub_v1/services/publisher/async_client.py

Line 1093 in 6b9eec8

gapic_version=pkg_resources.get_distribution("google-pubsub",).version,

python-pubsub/google/pubsub_v1/services/publisher/client.py

Line 1199 in 6b9eec8

gapic_version=pkg_resources.get_distribution("google-pubsub",).version,

python-pubsub/google/pubsub_v1/services/subscriber/client.py

Line 1904 in 6b9eec8

gapic_version=pkg_resources.get_distribution("google-pubsub",).version,

[plamut]

@cguardia This might be another one to get started, feel free to assign yourself if you have capacity.

[meredithslota]

Is this an issue with the code generator or something that should be fixed in the handwritten layers? cc: @anguillanneuf

[anguillanneuf]

The file structure looks a bit off. Why do we have pubsub and pubsub_v1 nested twice?

This is what we have currently.

- google/ 
  - cloud/
     - pubsub/
     - pubsub_v1/
     - __init__.py
  - pubsub
  - pubsub_v1
  - __init__.py

This is what we should have?

- google/
  - cloud/
     - pubsub/
     - pubsub_v1/
     - __init__.py

I referenced https://github.com/googleapis/python-vision/tree/master/google.

[plamut]

@anguillanneuf google/cloud/* is the hand-written code, while the code in google/pubsub and google/pubsub_v1 is generated by the microgenerator.

I don't remember exactly why this is the case, it might have been the most straightforward way to avoid any conflicts between the generated code and the hand-written code during the transition to the microgenerator. We might want to refactor this at some point, though, and configure thegenerator to generate the code under google/cloud/pubsub[_v1] to avoid confusion.

[plamut]

Looking at the ClientInfo docstring, gapic_version should be used for gapic-generated libraries. On the other hand, libraries that implement additional features on top the generated code should use the client_library_version argument (which is what get_distribution("google-cloud-pubsub") would return).

We can modify these pieces of generated code and provide the client library version, I'm sure the server-side analytics would benefit from it. If there's no setting in the generator itself, we can still do it through synth.py.

[anguillanneuf]

Thanks Peter for the link to ClientInfo docstring! Sounds like we should go with client_library_version = pkg_resources.get_distribution("google-cloud-pubsub",).version.