Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Open Telemetry Publish Side Support #1241

Merged
merged 20 commits into from
Sep 16, 2024
Merged

feat: Open Telemetry Publish Side Support #1241

merged 20 commits into from
Sep 16, 2024

Conversation

mukund-ananthu
Copy link
Contributor

@mukund-ananthu mukund-ananthu commented Aug 28, 2024

Publish Side Open Telemetry support. Related Issue: #543

@mukund-ananthu mukund-ananthu requested review from a team as code owners August 28, 2024 14:07
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Aug 28, 2024
Copy link

conventional-commit-lint-gcf bot commented Aug 28, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Aug 28, 2024
@mukund-ananthu mukund-ananthu changed the title Open Telemetry Publish Side Support feat: Open Telemetry Publish Side Support Aug 28, 2024
@mukund-ananthu mukund-ananthu self-assigned this Aug 28, 2024
@mukund-ananthu mukund-ananthu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 28, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 28, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Aug 28, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Aug 28, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Aug 28, 2024
@mukund-ananthu mukund-ananthu force-pushed the otel_publish branch 3 times, most recently from 8970477 to 54571f0 Compare August 28, 2024 17:33
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Aug 28, 2024
@mukund-ananthu mukund-ananthu force-pushed the otel_publish branch 7 times, most recently from 4d0704e to 8a939df Compare August 28, 2024 19:37
Copy link
Member

@hongalex hongalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit but otherwise LGTM

@mukund-ananthu mukund-ananthu force-pushed the otel_publish branch 5 times, most recently from 000e8a2 to 1c4933d Compare September 13, 2024 22:52
@mukund-ananthu mukund-ananthu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 13, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 13, 2024
@mukund-ananthu mukund-ananthu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 14, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 14, 2024
@mukund-ananthu mukund-ananthu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 14, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 14, 2024
@mukund-ananthu mukund-ananthu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 15, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 15, 2024
@mukund-ananthu mukund-ananthu merged commit bb5f3d1 into main Sep 16, 2024
26 of 27 checks passed
@mukund-ananthu mukund-ananthu deleted the otel_publish branch September 16, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants