From f98640bf2f268e27f292ed9b9f14556f12f690e9 Mon Sep 17 00:00:00 2001 From: Victor Chudnovsky Date: Thu, 14 Sep 2023 07:03:23 -0700 Subject: [PATCH] chore: remove obsolete replacement in owlbot.py (#633) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Remove owlbot.py workaround I manually checked that search string no longer exists in the noxfile specified in the workaround * Ping conventional commit bot * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Remove blank line * Fix to conform to canonical owlbot.py * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot Co-authored-by: Anthonios Partheniou --- noxfile.py | 1 + owlbot.py | 9 --------- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/noxfile.py b/noxfile.py index 3d7c4c92e..400073310 100644 --- a/noxfile.py +++ b/noxfile.py @@ -288,6 +288,7 @@ def docs(session): shutil.rmtree(os.path.join("docs", "_build"), ignore_errors=True) session.run( "sphinx-build", + "-W", # warnings as errors "-T", # show full traceback on exception "-N", # no colors "-b", diff --git a/owlbot.py b/owlbot.py index fc06bb569..ce738f01d 100644 --- a/owlbot.py +++ b/owlbot.py @@ -35,7 +35,6 @@ if clean_up_generated_samples: shutil.rmtree("samples/generated_samples", ignore_errors=True) clean_up_generated_samples = False - s.move([library], excludes=["**/gapic_version.py"]) s.remove_staging_dirs() @@ -52,14 +51,6 @@ python.py_samples(skip_readmes=True) -# Don't treat warnings as errors -# Docstrings have unexpected idnentation and block quote formatting issues -s.replace( - "noxfile.py", - '''["']-W["'], # warnings as errors''', - "", -) - # run format session for all directories which have a noxfile for noxfile in Path(".").glob("**/noxfile.py"): s.shell.run(["nox", "-s", "format"], cwd=noxfile.parent, hide_output=False)