Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Arrow extension-type metadata was not set when calling the REST API or when there are no rows #946

Merged
merged 6 commits into from
Sep 7, 2021
Merged

fix: Arrow extension-type metadata was not set when calling the REST API or when there are no rows #946

merged 6 commits into from
Sep 7, 2021

Conversation

jimfulton
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #894 🦕

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Sep 6, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 6, 2021
@jimfulton jimfulton marked this pull request as ready for review September 6, 2021 19:28
@jimfulton jimfulton requested a review from a team September 6, 2021 19:28
@jimfulton jimfulton requested a review from a team as a code owner September 6, 2021 19:28
@jimfulton jimfulton changed the title fix: Arror extension-type metadata not set when calling the REST API or when there are no rows fix: Arrow extension-type metadata not set when calling the REST API or when there are no rows Sep 6, 2021
@jimfulton jimfulton changed the title fix: Arrow extension-type metadata not set when calling the REST API or when there are no rows fix: Arrow extension-type metadata was not set when calling the REST API or when there are no rows Sep 6, 2021
plamut
plamut reviewed Sep 7, 2021
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits/questions, but generally looks good to me.

google/cloud/bigquery/_pandas_helpers.py Show resolved Hide resolved
google/cloud/bigquery/table.py Show resolved Hide resolved
tests/system/test_arrow.py Outdated Show resolved Hide resolved
plamut
plamut approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jimfulton jimfulton merged commit 864383b into googleapis:main Sep 7, 2021
@jimfulton jimfulton deleted the arrow-extension-types-894 branch September 7, 2021 15:16
tswast
tswast reviewed Sep 7, 2021
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
@jimfulton @abdelmegahedgoogle
fix: Arrow extension-type metadata was not set when calling the REST …
7f5796b 
…API or when there are no rows (googleapis#946)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast left review comments

@plamut plamut plamut approved these changes

@loferris loferris Awaiting requested review from loferris

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: ensure Arrow type metadata is consistent between REST and BQ Storage APIs
3 participants
@jimfulton @tswast @plamut