-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for Parquet options #679
Conversation
For load jobs and external tables config.
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
We still need to expose |
@googlebot I fixed it. |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
1 similar comment
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Exposed the config object in |
@plamut My team is currently a bit blocked because this functionality is missing from the BigQuery Python library. Is there anything we can do to help this get merged and released? Maybe some testing? |
@simonvanderveldt Thanks for bumping this, it appears that it's incorrectly blocked by the CLA bot (and still needs one approval). @shollyman Can you please convince the bot to change its mind? :) And add a review, if possible?
If you want, you can test the BigQuery client with this PR branch, but primarily someone from Google with sufficient permissions needs to unblock the PR first. |
Just tested it, working as expected :) We only need the list inference and using the library from this PR gives the same results as when using |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Looks like we're missing CLA signing from |
But Tres is a well-known contributor? Or is it because a different email address was used? |
@plamut I looks like there is no CLA for I think if you edit the |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
That trick with editing the commit message worked, great! Since we also have an approval now, I'll merge and release this today. |
@busunkim96 As for the CLA bot, isn't this a bit fragile? Theoretically one could take another person's work posted as a suggestion, edit out the line in the commit message linking to that person, and then merge a non-CLA code into the project? We can discuss this offline. |
@simonvanderveldt The changes have just been released, happy coding! |
@plamut Awesome! Thanks a lot for the quick merge and release! |
@busunkim96 literally all of my commits to Google's repositories over the last seven years have been signed with the |
Closes #661.
For load jobs and external tables config.
PR checklist: