Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): invalid path to strptime() #672

Merged
merged 1 commit into from
May 21, 2021
Merged

fix(tests): invalid path to strptime() #672

merged 1 commit into from
May 21, 2021

Conversation

plamut
Copy link
Contributor

@plamut plamut commented May 20, 2021

Fixes #671.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut requested a review from jimfulton May 20, 2021 08:38
@plamut plamut requested a review from a team as a code owner May 20, 2021 08:38
@plamut plamut requested review from kurtisvg and removed request for a team May 20, 2021 08:38
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 20, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label May 20, 2021
@plamut
Copy link
Contributor Author

plamut commented May 20, 2021

Re-echoing a comment here - why wasn't this detected earlier, do we have a glitch in the CI pipeline? The PR that caused this was merged more than 3 weeks ago.

jimfulton
jimfulton approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@jimfulton jimfulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering why we didn't hit this before, but I guess this method is only called during cleanup that isn't usually needed.

Maybe we should write a test for this.

kurtisvg
kurtisvg approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The periodic sample tests for this repo have had 37 straight days. So it's probably not (just) a glitch in the pipeline, it's that no one is watching the results.

@plamut
Copy link
Contributor Author

plamut commented May 21, 2021

So it's probably not (just) a glitch in the pipeline, it's that no one is watching the results.

Where can those be seen, or is that an internal thing?
(as an external maintainer I can only the Kokoro checks here on GitHub)

@plamut plamut merged commit 591cdd8 into googleapis:master May 21, 2021
@plamut plamut deleted the iss-671 branch May 21, 2021 09:03
@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtisvg kurtisvg kurtisvg approved these changes

@jimfulton jimfulton jimfulton approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AttributeError in resource_name_to_date() samples fixture
3 participants
@plamut @jimfulton @kurtisvg