Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting job_config.source_format is ignored by load_table_from_dataframe #261

Closed
tswast opened this issue Sep 15, 2020 · 0 comments · Fixed by #262
Closed

Setting job_config.source_format is ignored by load_table_from_dataframe #261

tswast opened this issue Sep 15, 2020 · 0 comments · Fixed by #262
Assignees
@HemangChothani
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tswast
Copy link
Contributor

tswast commented Sep 15, 2020

Currently on PARQUET is supported. If someone sets the format to something other than that, we should probably raise a ValueError.

Might want to consider support CSV / JSON / AVRO, but also don't want to explode the number of (already numerous) code paths we have for DataFrame loading.
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Sep 15, 2020
@tswast tswast added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed api: bigquery Issues related to the googleapis/python-bigquery API. labels Sep 15, 2020
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Sep 16, 2020
@HemangChothani HemangChothani self-assigned this Sep 16, 2020
@HemangChothani HemangChothani mentioned this issue Sep 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HemangChothani HemangChothani

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: validate job_config.source_format in load_table_from_dataframe MaxxleLLC/python-bigquery
2 participants
@tswast @HemangChothani