Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenTelemetry] Can we add the db.query.text attribute to the spans? #2042

Open
Kludex opened this issue Oct 18, 2024 · 4 comments · May be fixed by #2061
Open

[OpenTelemetry] Can we add the db.query.text attribute to the spans? #2042

Kludex opened this issue Oct 18, 2024 · 4 comments · May be fixed by #2061
Assignees
Labels
api: bigquery Issues related to the googleapis/python-bigquery API.

Comments

@Kludex
Copy link

Kludex commented Oct 18, 2024

Hi there,

I was wondering if it would be possible to add the query itself in the span attributes. The list of official OTel attributes for db are listed here.

I'm happy to implement it, if wanted.

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Oct 18, 2024
@williamlac
Copy link

+1

This would be a great addition to help us identify which span is related to which of our queries in a much faster way.

@samuelcolvin
Copy link

This would be great, @chelsea-lin can you let us know if you would accept a PR for this?

@Kludex
Copy link
Author

Kludex commented Nov 13, 2024

Hoi 👋

Friendly ping 🏓 😃

@chelsea-lin
Copy link
Contributor

@Kludex Thank you! It sounds good to me! Please go ahead to start the PR please.

@Kludex Kludex linked a pull request Nov 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants