Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArrayQueryParameter.from_api_repr does not support empty array #2009

Open
TommyDew42 opened this issue Sep 3, 2024 · 0 comments · May be fixed by #2010
Open

ArrayQueryParameter.from_api_repr does not support empty array #2009

TommyDew42 opened this issue Sep 3, 2024 · 0 comments · May be fixed by #2010
Assignees
@chalmerlowe
Labels
api: bigquery Issues related to the googleapis/python-bigquery API.

Comments

@TommyDew42
Copy link

The ArrayQueryParameter class must take a StructQueryParameterType if the values is an empty array (docstring):

If the type is 'STRUCT'/'RECORD' and values is empty,
the exact item type cannot be deduced, thus a StructQueryParameterType
instance needs to be passed in.

But in the method _from_api_repr_struct, we simply pass "STRUCT" as the array_type.
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Sep 3, 2024
@TommyDew42 TommyDew42 linked a pull request Sep 3, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chalmerlowe chalmerlowe

Labels
api: bigquery Issues related to the googleapis/python-bigquery API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support empty array in _from_api_repr_struct TommyDew42/python-bigquery
3 participants
@alvarowolfx @chalmerlowe @TommyDew42